monkeyDluffy6017 commented on code in PR #10445: URL: https://github.com/apache/apisix/pull/10445#discussion_r1384543673
########## apisix/discovery/nacos/init.lua: ########## @@ -39,6 +39,8 @@ local auth_path = 'auth/login' local instance_list_path = 'ns/instance/list?healthyOnly=true&serviceName=' local default_namespace_id = "public" local default_group_name = "DEFAULT_GROUP" +local access_key +local secret_key Review Comment: So it's for MSE only? Could you describe this in the comment? like ``` # access_key: "" # Nacos AccessKey ID in Alibaba Cloud, notice that it's for Nacos instances on Microservices Engine (MSE) # secret_key: "" # Nacos AccessKey Secret in Alibaba Cloud, notice that it's for Nacos instances on Microservices Engine (MSE) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
