Yiyiyimu commented on a change in pull request #2299:
URL: https://github.com/apache/apisix/pull/2299#discussion_r495411846
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,10 +181,6 @@ local function sync_data(self)
return false, err
end
- if not dir_res.dir then
- return false, self.key .. " is not a dir"
- end
-
Review comment:
Currently I still set `dir = true` in [etcd protocol
conversion](https://github.com/apache/apisix/blob/9ac02f66b14fa3c1b5a8f9341a82b664ceda17fb/apisix/core/etcd.lua#L61)
for consistency between protocols. But I noticed there is only one test case
([global.t TEST
3](https://github.com/apache/apisix/blob/9ac02f66b14fa3c1b5a8f9341a82b664ceda17fb/t/admin/global-rules.t#L125-L127))
needs this parameter, so maybe we could remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
