TomCN0803 commented on code in PR #151: URL: https://github.com/apache/apisix-go-plugin-runner/pull/151#discussion_r1400644345
########## .gitignore: ########## @@ -7,3 +7,6 @@ release/ coverage.txt logs/ *.svg +/.vscode +go.work +go.work.sum Review Comment: - go.work & go.work.sum: Are go workspace related files (https://go.dev/doc/tutorial/workspaces) which should be gitignored. Go workspace is used to work with multiple go modules and our project contains two go modules (project root and ./tests/e2e); - .vscode: Is vscode editor related folder that contains user specific vscode settings, which definately shouldn't be committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
