Revolyssup commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401802642
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
stream_route doesn't have metadata field also. If it has that,labels could
be pushed there. Ingress needs some field to add the labels, so the schema will
need change here.
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
stream_route doesn't have metadata field also. If it had that,labels could
be pushed there. Ingress needs some field to add the labels, so the schema will
need change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
