Vacant2333 commented on issue #10494: URL: https://github.com/apache/apisix/issues/10494#issuecomment-1838909509
I am currently unsure how to address this issue. Our goal is to have the logger output in the form of a full log by default. The current situation is that all loggers output in the full log format (contrary to the documentation), and the [metadata_schema_log_format](https://github.com/apache/apisix/blob/225e18f389a7593f356599999e41f77418e7732c/apisix/utils/log-util.lua#L35C26-L35C26) does not seem to take effect at all, even though almost every logger [references it](https://github.com/apache/apisix/blob/225e18f389a7593f356599999e41f77418e7732c/apisix/plugins/kafka-logger.lua#L137). We have two implementation options: 1. Remove all unused code and output in the full log format. 2. Set the full log format as the default format, meaning to make the previously ineffective code effective and switch to the full log. I am currently attempting the second option, which may result in some unreasonable changes: 1. The current full log includes entries [such as](https://github.com/apache/apisix/blob/225e18f389a7593f356599999e41f77418e7732c/apisix/utils/log-util.lua#L157C1-L159C40): - latency - upstream_latency - apisix_latency and similar entries not present in the apisix/nginx variables. It might be unreasonable to handle these entries separately. 2. The current full log has a [two-layer structure](https://github.com/apache/apisix/blob/225e18f389a7593f356599999e41f77418e7732c/apisix/utils/log-util.lua#L134C13-L134C13), but the logger's provided log format is [single-layered](https://github.com/apache/apisix/blob/225e18f389a7593f356599999e41f77418e7732c/apisix/utils/log-util.lua#L63C15-L63C15) (multi-layered structure has been implemented in the [PR](https://github.com/apache/apisix/pull/10588)). In summary, I need some assistance with the above. cc @kayx23 @shreemaan-abhishek and maybe more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
