Revolyssup commented on code in PR #2078:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2078#discussion_r1415594566
##########
test/e2e/suite-features/external-service.go:
##########
@@ -159,18 +155,18 @@ spec:
Status(http.StatusOK)
}
- PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId
string, code int) {
- routes, err := s.ListApisixRoutes()
- assert.Nil(ginkgo.GinkgoT(), err)
- assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
- assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
+ // PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold,
upstreamId string, code int) {
+ // routes, err := s.ListApisixRoutes()
+ // assert.Nil(ginkgo.GinkgoT(), err)
+ // assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
+ // assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
- _ = s.NewAPISIXClient().GET("/ip").
- WithHeader("Host", "httpbin.org").
- WithHeader("X-Foo", "bar").
- Expect().
- Status(code)
- }
+ // _ = s.NewAPISIXClient().GET("/ip").
+ // WithHeader("Host", "httpbin.org").
+ // WithHeader("X-Foo", "bar").
+ // Expect().
+ // Status(code)
+ // }
Review Comment:
might be helpful in future
##########
test/e2e/suite-features/external-service.go:
##########
@@ -159,18 +155,18 @@ spec:
Status(http.StatusOK)
}
- PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId
string, code int) {
- routes, err := s.ListApisixRoutes()
- assert.Nil(ginkgo.GinkgoT(), err)
- assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
- assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
+ // PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold,
upstreamId string, code int) {
+ // routes, err := s.ListApisixRoutes()
+ // assert.Nil(ginkgo.GinkgoT(), err)
+ // assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
+ // assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
- _ = s.NewAPISIXClient().GET("/ip").
- WithHeader("Host", "httpbin.org").
- WithHeader("X-Foo", "bar").
- Expect().
- Status(code)
- }
+ // _ = s.NewAPISIXClient().GET("/ip").
+ // WithHeader("Host", "httpbin.org").
+ // WithHeader("X-Foo", "bar").
+ // Expect().
+ // Status(code)
+ // }
Review Comment:
not being used right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
