baqianxin commented on PR #10609: URL: https://github.com/apache/apisix/pull/10609#issuecomment-1844871789
> But now that you mentioned and I happened to be double checking the code, it seems the default value is actually not 900... It doesn't have a default value: https://github.com/zmartzone/lua-resty-openidc/blob/master/lib/resty/openidc.lua#L1545 > > Note that the attribute values in README for `lua-resty-openidc` aren't always the default value... > > Maybe you could re-position this PR as a fix to correct it (docs and schema in `openid-connect.lua`). Your updates were very prompt, and I followed your suggestions to modify the default values and documentation description. Thanks. I just checked the documentation site to see if the relevant parameters existed, without reviewing the latest code, and then modified the document content to submit a pull request.Thanks again for your reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
