kayx23 commented on code in PR #2096:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2096#discussion_r1423582577
##########
docs/en/latest/concepts/apisix_route.md:
##########
@@ -262,6 +262,46 @@ spec:
secretRef: echo
```
+## Config with secretRef configuring nested fields
+
+You can also configure specific fields in the plugin configuration that are
deeply nested by passing the path to that field. The path is dot-separated keys
that lead to that field. The below example overrides the `X-Foo` header field
in the plugin configuration from `v1` to `v2`.
+
+```yaml
+apiVersion: v1
+kind: Secret
+metadata:
+ #content is "v2"
+ name: echo
+data:
+ headers.X-Foo: djI=
Review Comment:
1. Does this have to be base64 encoded? If so, perhaps should be mentioned?
2. Instead of putting a comment `#content is "v2"`, you could _consider_
mention `djI=` is base64 encoded v2 in the paragraph above?
##########
docs/en/latest/concepts/apisix_route.md:
##########
@@ -262,6 +262,46 @@ spec:
secretRef: echo
```
+## Config with secretRef configuring nested fields
+
+You can also configure specific fields in the plugin configuration that are
deeply nested by passing the path to that field. The path is dot-separated keys
that lead to that field. The below example overrides the `X-Foo` header field
in the plugin configuration from `v1` to `v2`.
+
+```yaml
+apiVersion: v1
+kind: Secret
+metadata:
+ #content is "v2"
+ name: echo
+data:
+ headers.X-Foo: djI=
Review Comment:
1. Does this have to be base64 encoded? If so, perhaps should be mentioned?
2. Instead of putting a comment `#content is "v2"`, you could _consider_
mentioning `djI=` is base64 encoded v2 in the paragraph above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
