jujiale commented on PR #10644:
URL: https://github.com/apache/apisix/pull/10644#issuecomment-1854974350

   > In my [past tests with other logger 
plugins](https://github.com/apache/apisix/pull/10476#issuecomment-1809719588), 
the `name` is actually configurable and gets exported to prometheus 
`apisix_batch_process_entries` metric.
   > 
   > 
![image](https://private-user-images.githubusercontent.com/39619599/290366392-488347f8-8cd6-492b-b829-364d73df9e13.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDI1MTg1NzEsIm5iZiI6MTcwMjUxODI3MSwicGF0aCI6Ii8zOTYxOTU5OS8yOTAzNjYzOTItNDg4MzQ3ZjgtOGNkNi00OTJiLWI4MjktMzY0ZDczZGY5ZTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjE0VDAxNDQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJlOGUzNmIxMjQ5YzI4YzQwZTUyNzZjMTEzMTU5MWNlZWM1ZmM1M2ZiMWJlNzBmODAyNGM0N2E0YzNkMDY4ZmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kuiuWMNHvIVz5sZmtU0lSQv668hxY49GAcyB2NUfoVE)
   > 
   > https://github.com/search?q=repo%3Aapache%2Fapisix+sys-logger&type=code
   > 
   > You can change `"name": "sys-logger"` to a different value and see if test 
will pass, to verify if the field is actually configurable.
   
   I checked it. it's my negligence, I have created a new pr to revert it. 
thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to