membphis commented on a change in pull request #2299:
URL: https://github.com/apache/apisix/pull/2299#discussion_r495827965



##########
File path: apisix/core/config_etcd.lua
##########
@@ -123,6 +124,15 @@ local function waitdir(etcd_cli, key, modified_index, 
timeout)
         res, err = res_func()
     end
 
+    if http_cli then
+        local res_cancel, err_cancel = etcd_cli:watchcancel(http_cli)
+        if res_cancel and res_cancel == 1 then

Review comment:
       `if res_cancel == 1 then` is enough




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to