theweakgod commented on PR #10697: URL: https://github.com/apache/apisix/pull/10697#issuecomment-1868802675
> I've taken a closer look at the requirement and I've realised that it's not very clear and there's probably no way to make it a very generic feature, e.g. whether the health check request sent needs to carry a specific body of the request, whether the health check result returned should be checked for a particular field or for the whole result. These 2 issues describe 2 different requirements: #10517 and #9920 > I've taken a closer look at the requirement and I've realised that it's not very clear and there's probably no way to make it a very generic feature, e.g. whether the health check request sent needs to carry a specific body of the request, whether the health check result returned should be checked for a particular field or for the whole result. These 2 issues describe 2 different requirements: #10517 and #9920 I think it is better for the health check to do a simple whole-body verification, without considering the content-type. Some users may really need a simple body verification to determine whether they are healthy. If you target a certain field, different content-types will make the parsing more complicated. I think the easiest and best way at present is to verify the entire body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
