kayx23 opened a new pull request, #10727:
URL: https://github.com/apache/apisix/pull/10727

   ### Description
   
   Mention env var support in `apisix.yaml` and add a caution note for 
exporting vars.
   
   See the below issues for more background info:
   
   Closes #10509 
   Closes #10530
   
   The info is also mentioned in the [Admin API 
doc](https://apisix.apache.org/docs/apisix/admin-api/#using-environment-variables)
 but not easy to locate. Personally I only found out after looking for the PR 
that adds the feature.
   
   From a user perspective, when I search for apisix config env var, this is 
the doc that comes up first.
   
   
![image](https://github.com/apache/apisix/assets/39619599/e1ec9aba-19af-40ed-8f55-2de11ac026c6)
   
   There has been other user that recently mentioned the info could not be 
located:
   
   
![image](https://github.com/apache/apisix/assets/39619599/f9897147-03fa-45b8-a1af-40d27f07a3a9)
   
   https://the-asf.slack.com/archives/CUC5MN17A/p1703518877003939
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to