AlinsRan commented on code in PR #10724:
URL: https://github.com/apache/apisix/pull/10724#discussion_r1437324313
##########
.github/workflows/cli-master.yml:
##########
@@ -6,11 +6,6 @@ on:
paths-ignore:
- 'docs/**'
- '**/*.md'
- pull_request:
- branches: [master]
- paths-ignore:
- - 'docs/**'
- - '**/*.md'
Review Comment:
This CI is used to test whether the Rockspec for **remotely pulling** the
master branch can be installed.
https://github.com/apache/apisix/blob/40eb0c9b193d43ff25420640af1c3601b02d6847/ci/common.sh#L26
https://github.com/apache/apisix/blob/40eb0c9b193d43ff25420640af1c3601b02d6847/ci/linux_apisix_master_luarocks_runner.sh#L43
It is meaningless for PR, assuming that a third-party library in Rockspec
has been updated and a certain field has been adjusted, then PR cannot pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
