boekkooi-lengoo commented on code in PR #10645:
URL: https://github.com/apache/apisix/pull/10645#discussion_r1437843588


##########
apisix/core/ctx.lua:
##########
@@ -274,6 +274,15 @@ do
                     end
                 end
 
+            elseif core_str.has_prefix(key, "uri_arg_") then

Review Comment:
   Partially correct, as `curr_req_matched` is set in 
https://github.com/apache/apisix/blob/538b964c3bb5a60d8b6016aa0b552439c6307f1b/apisix/http/router/radixtree_host_uri.lua#L83
 and based on 
https://github.com/apache/apisix/blob/538b964c3bb5a60d8b6016aa0b552439c6307f1b/apisix/http/router/radixtree_host_uri.lua#L179
 it seems `_host` is even valid without `radixtree_uri_with_parameter` also 
looking at 
[`lib/resty/radixtree.lua`](https://github.com/api7/lua-resty-radixtree/blob/master/lib/resty/radixtree.lua)
 it seems `_action`, `_path` and `_host` can be available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to