monkeyDluffy6017 commented on code in PR #10696:
URL: https://github.com/apache/apisix/pull/10696#discussion_r1440121568
##########
apisix/cli/ops.lua:
##########
@@ -792,10 +803,8 @@ local function start(env, ...)
end
-- check running
- local pid_path = env.apisix_home .. "/logs/nginx.pid"
- local pid = util.read_file(pid_path)
- pid = tonumber(pid)
- if pid then
+ local running, pid = check_running(env)
Review Comment:
we can wait in the `check_running`, return true if the old process exits
successfully, return false if reach the deadline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
