markusmueller opened a new pull request, #10788:
URL: https://github.com/apache/apisix/pull/10788

   …l expired when using lockable session storage backend (#8017)
   
   ### Description
   
   Fixes #8017
   
   I'm not a Lua developer but I'd really like to see this fixed. It might be 
appropriate to wrap with a pcall and have the session closed in any case 
(try-catch-finally). Also, I couldn't quickly figure out if the testing would 
cover configuring and spinning up a locking session storage (memcache for 
example) to test this. If so, happy to add a test case.
   
   Thank you for your feedback. 
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to