shreemaan-abhishek commented on code in PR #10837: URL: https://github.com/apache/apisix/pull/10837#discussion_r1455116949
########## apisix/upstream.lua: ########## @@ -81,7 +81,11 @@ end _M.set = set_directly -local function release_checker(healthcheck_parent) +local function release_checker(healthcheck_parent, is_compacted) + if is_compacted then Review Comment: could you clarify more? My changes will not release the checker only when the reason is compaction. There is still another case that can release the checkers properly: https://github.com/shreemaan-abhishek/apisix/blob/105993f40f34768cd0a86035d01393346fff3a94/apisix/core/config_etcd.lua#L686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
