Vacant2333 commented on code in PR #10864:
URL: https://github.com/apache/apisix/pull/10864#discussion_r1463074018
##########
utils/install-dependencies.sh:
##########
@@ -81,12 +81,6 @@ function install_dependencies_with_apt() {
sudo apt-get install -y curl make gcc g++ cpanminus libpcre3 libpcre3-dev
libldap2-dev unzip openresty-zlib-dev openresty-pcre-dev
}
-# Install dependencies on mac osx
-function install_dependencies_on_mac_osx() {
- # install OpenResty, etcd and some compilation tools
- brew install openresty/brew/openresty luarocks [email protected] wget curl git pcre
openldap
Review Comment:
hi, i have update this, in fact, if it is Mac in this logic, it will
indicate that the current platform is not supported, so I did not add a new
prompt.
<img width="1097" alt="image"
src="https://github.com/apache/apisix/assets/19872346/8cf478b9-3da3-4e04-b1f8-427d93d91afc";>
But there is another problem with this code. Even the unsupported platform
`make deps` will continue to execute, so I added an `exit 1` to interrupt it.
<img width="1109" alt="image"
src="https://github.com/apache/apisix/assets/19872346/b8f05258-e7e4-4870-8c87-b7b212e051bb";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
