AlinsRan commented on code in PR #2146:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2146#discussion_r1464358686
##########
pkg/providers/apisix/apisix_consumer.go:
##########
@@ -184,15 +184,6 @@ func (c *apisixConsumerController) handleSyncErr(obj
interface{}, err error) {
c.MetricsCollector.IncrSyncOperation("consumer", "success")
return
}
- event := obj.(*types.Event)
Review Comment:
dito
##########
pkg/providers/apisix/apisix_cluster_config.go:
##########
@@ -219,15 +219,6 @@ func (c *apisixClusterConfigController) handleSyncErr(obj
interface{}, err error
c.MetricsCollector.IncrSyncOperation("clusterConfig", "success")
return
}
- event := obj.(*types.Event)
Review Comment:
refs: https://github.com/apache/apisix-ingress-controller/issues/810
1. There may be an expired event during the retry, which means it was
deleted when the retry occurred, and this event will continue to be triggered.
2. What is the reason why this resource status needs to be retried? What
should be the retry strategy? I think rough deletion is not advisable.
3. The changes here are not related to the title of the PR. If you think you
need to try again, please submit a separate PR for discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
