shreemaan-abhishek commented on code in PR #10872:
URL: https://github.com/apache/apisix/pull/10872#discussion_r1469554764
##########
apisix/plugins/mocking.lua:
##########
@@ -229,6 +229,7 @@ function _M.access(conf, ctx)
if conf.response_headers then
for key, value in pairs(conf.response_headers) do
+ value = core.utils.resolve_var(value, ctx.var)
Review Comment:
`resolve_var` may return nil. Please cover this case. Also add test case for
this situtation,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
