zll600 commented on code in PR #682:
URL: https://github.com/apache/apisix-helm-chart/pull/682#discussion_r1471392638
##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -183,6 +183,25 @@ affinity: {}
# ref:
https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/#spread-constraints-for-pods
topologySpreadConstraints: []
+# -- timezone is the timezone where apisix uses.
Review Comment:
```suggestion
# -- timezone is the timezone where apisix-ingress-controller uses.
```
##########
charts/apisix-ingress-controller/README.md:
##########
@@ -185,6 +186,7 @@ The same for container level, you need to set:
| serviceMonitor.annotations | object | `{}` | @param
serviceMonitor.annotations ServiceMonitor annotations |
| serviceMonitor.labels | object | `{}` | @param serviceMonitor.labels
ServiceMonitor extra labels |
| serviceMonitor.metricRelabelings | object | `{}` | @param
serviceMonitor.metricRelabelings MetricRelabelConfigs to apply to samples
before ingestion. ref:
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs
|
+| timezone | string | `""` | timezone is the timezone where apisix uses. For
example: "UTC" or "Asia/Shanghai" This value will be set on
apisix-ingress-controller container's environment variable TZ. You may need to
set the timezone to be consistent with your local time zone, otherwise the
apisix-ingress-controller's logs may be used to retrieve event in wrong
timezone. |
Review Comment:
```suggestion
| timezone | string | `""` | timezone is the timezone where
apisix-ingress-controller uses. For example: "UTC" or "Asia/Shanghai" This
value will be set on apisix-ingress-controller container's environment variable
TZ. You may need to set the timezone to be consistent with your local time
zone, otherwise the apisix-ingress-controller's logs may be used to retrieve
event in wrong timezone. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
