acuteaura commented on PR #2152: URL: https://github.com/apache/apisix-ingress-controller/pull/2152#issuecomment-1919274826
some remarks on this PR: * a bunch of code seems to treat leader status as "skipping writes" (via the `Elector`). this is pretty hard to reason about and prone to errors, so this PR changes it to a more traditional standby (with informers warmed up) that doesn't run any controllers. * alongside that, the controller now hard exits when it loses leader status. * `run` got an error return value, because a lot of error conditions were just silently unhandled. A future PR should improve these errors with some kind of wrapping and remove explicit logging in `run` itself so it all bubbles up * I did not touch the API server, because I'm not 100% about all the things it does, but we should consider failing a readiness probe if it is not leader if code in there relies on controllers running - though it did not have access to `Elector` until this point either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
