AlinsRan commented on code in PR #2148:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2148#discussion_r1474143856
##########
cmd/ingress/ingress.go:
##########
@@ -177,6 +177,7 @@ For example, no available LB exists in the bare metal
environment.`)
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressClass,
"ingress-class", config.IngressClassApisixAndAll, "apisix-and-all is a special
value, it handles Ingress resources with ingressClassName=apisix and all CRDs,
the class of an Ingress object is set using the field IngressClassName in
Kubernetes clusters version v1.18.0 or higher or the annotation
\"kubernetes.io/ingress.class\" (deprecated)")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ElectionID,
"election-id", config.IngressAPISIXLeader, "election id used for campaign the
controller leader")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressVersion,
"ingress-version", config.IngressNetworkingV1, "the supported ingress api group
version, can be \"networking/v1beta1\", \"networking/v1\" (for Kubernetes
version v1.19.0 or higher) and \"extensions/v1beta1\"")
+ cmd.PersistentFlags().StringVar(&cfg.Kubernetes.GatewayVersion,
"gateway-version", config.GatewayNetworkingV1, "the supported gateway api group
version, can be \"gateway/v1beta1\", \"gateway/v1\"")
Review Comment:
I think the `gateway-version` is not very suitable as it usually represents
the version of the data plane proxy.
I suggest: `gateway-api-version` ,`gatewayapi-version` or ...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
