Vacant2333 commented on PR #10883:
URL: https://github.com/apache/apisix/pull/10883#issuecomment-1931380021

   > > > @Vacant2333 you must also update the schema, shouldn't you? And is 
there any spec/rfc that supports your claim?
   > > 
   > > 
   > > no, we cant limit the schemea, if use set `is_base64_encoded` to `true`, 
the secret will longger than 32 chars. u can check this testcase, the secret 
after base64_encode will be longer than 32chars 
https://github.com/apache/apisix/blob/master/t/plugin/jwe-decrypt.t#L348
   > 
   > @Vacant2333 In that case, why is this PR still saying the secret must be 
32 chars, instead of explaining more of what you explain above?
   
   yes, u r right! i will raise a pr to mention these infomations, and it will 
check the secret length when APISIX running


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to