kayx23 commented on code in PR #10928:
URL: https://github.com/apache/apisix/pull/10928#discussion_r1482519566
##########
docs/en/latest/plugins/jwe-decrypt.md:
##########
@@ -44,6 +44,12 @@ For Consumer:
| secret | string | True
| | | The decryption key. Must be 32
characters. The key could be saved in a secret manager using the
[Secret](../terminology/secret.md) resource. |
| is_base64_encoded | boolean | False
| false | | Set to true if the secret is
base64 encoded.
|
+:::note
+
+After enabling `is_base64_encoded`, your `secret` length may exceed 32 chars.
You only need to make sure that the length after Decode is still 32 chars.
Review Comment:
```suggestion
After enabling `is_base64_encoded`, your `secret` length may exceed 32
chars. You only need to make sure that the length after decoding is still 32
chars.
```
tbh i think this info should go into the description of `secret`, rather
than a note at the bottom (if its not too difficult to read)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
