shreemaan-abhishek commented on code in PR #10916:
URL: https://github.com/apache/apisix/pull/10916#discussion_r1484952910
##########
apisix/discovery/kubernetes/informer_factory.lua:
##########
@@ -355,7 +355,7 @@ function _M.new(group, version, kind, plural, namespace)
end
if namespace and namespace ~= "" then
- path = path .. "/namespace/" .. namespace
+ path = path .. "/namespaces/" .. namespace
Review Comment:
> It's must for e2e case. Squash and merge in last pull merge
I don't understand you but let me clarify myself. A PR should only contain
related changes. If this PR depends upon another feature/bug fix. The other
feature should be merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
