shreemaan-abhishek commented on code in PR #10917:
URL: https://github.com/apache/apisix/pull/10917#discussion_r1485205653
##########
t/kubernetes/discovery/kubernetes2.t:
##########
@@ -99,6 +99,21 @@ _EOC_
$block->set_value("main_config", $main_config);
my $config = $block->config // <<_EOC_;
+ location /informer {
Review Comment:
this test case doesn't make sense. It is difficult to understand what
problem this PR fixes (although from the link that you shared, it appears that
the url is incorrect).. so in theory... namespace based queries should fail
(given the path is incorrect)...
can you show in a test case that namespace related queries pass now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
