shreemaan-abhishek commented on code in PR #10887:
URL: https://github.com/apache/apisix/pull/10887#discussion_r1495344941
##########
ci/common.sh:
##########
@@ -75,6 +75,15 @@ install_curl () {
curl -V
}
+install_apisix_runtime() {
+ export runtime_version=${APISIX_RUNTIME}
+ # I need to use script from my repo to test
Review Comment:
?
##########
utils/install-dependencies.sh:
##########
@@ -121,7 +121,8 @@ function multi_distro_uninstallation() {
function install_apisix_runtime() {
export runtime_version=${APISIX_RUNTIME:?}
- wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime.sh";
+ # wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime.sh";
+ wget
"https://raw.githubusercontent.com/zll600/apisix-build-tools/upgrade_openresty-1.25.3.1/build-apisix-runtime.sh";
Review Comment:
?
##########
ci/common.sh:
##########
@@ -75,6 +75,15 @@ install_curl () {
curl -V
}
+install_apisix_runtime() {
+ export runtime_version=${APISIX_RUNTIME}
+ # I need to use script from my repo to test
+ # wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime.sh";
+ wget
"https://raw.githubusercontent.com/zll600/apisix-build-tools/upgrade_openresty-1.25.3.1/build-apisix-runtime.sh";
Review Comment:
?
##########
apisix/plugins/ext-plugin/init.lua:
##########
@@ -935,13 +935,14 @@ end
local runner
local function setup_runner(cmd)
- runner = spawn_proc(cmd)
ngx_timer_at(0, function(premature)
if premature then
return
end
+ runner = spawn_proc(cmd)
+
Review Comment:
why it used to work without any problem in the previous version?
##########
apisix/core/request.lua:
##########
@@ -282,6 +282,17 @@ function _M.get_body(max_size, ctx)
end
end
+ -- TODO: solve this issue correctly.
+ local var = ctx and ctx.var or ngx.var
+ local content_length = tonumber(var.http_content_length) or 0
+ if (var.server_protocol == "HTTP/2.0" or var.server_protocol == "HTTP/3.0")
+ and content_length == 0 then
+ -- Due to the stream processing feature of HTTP/2 or HTTP/3,
+ -- this api could potentially block the entire request. Therefore,
+ -- this api is effective only when HTTP/2 or HTTP/3 requests send
content-length header.
+ -- For requests with versions lower than HTTP/2, this api can still be
used without any problems.
+ return nil
+ end
Review Comment:
can we explicitly calculate the content_length and add it as a header to fix
this issue? If it is simple to fix we should do that right away. If not, then
we should create an issue to track this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
