imjoey commented on a change in pull request #2345:
URL: https://github.com/apache/apisix/pull/2345#discussion_r502123384
##########
File path: apisix/schema_def.lua
##########
@@ -555,6 +580,14 @@ _M.ssl = {
type = "integer",
minimum = 1588262400, -- 2020/5/1 0:0:0
},
+ labels = {
Review comment:
@nic-chen IMHO, we could use label to distinguish among dozens of SSLs
according to their usage.
##########
File path: apisix/schema_def.lua
##########
@@ -555,6 +580,14 @@ _M.ssl = {
type = "integer",
minimum = 1588262400, -- 2020/5/1 0:0:0
},
+ labels = {
Review comment:
@membphis @liuxiran any thoughts on this? 😄
##########
File path: apisix/schema_def.lua
##########
@@ -555,6 +580,14 @@ _M.ssl = {
type = "integer",
minimum = 1588262400, -- 2020/5/1 0:0:0
},
+ labels = {
Review comment:
@nic-chen thanks for response. IMHO, we could use label to distinguish
among dozens of SSLs according to their usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
