dtsek commented on PR #11059: URL: https://github.com/apache/apisix/pull/11059#issuecomment-2014829171
Hello @shreemaan-abhishek , unfortunately I cannot provide for the time being a test case because in https://github.com/apache/apisix/blob/c0e3d9150f06c3140a52d145782085d26bc1ea67/ci/pod/keycloak/kcadm_configure_university.sh there is only one client being configured and I would like to avoid modifying many services outside of the plugin. In order to create a test case to prove the bugfix I will need two valid clients. The correct one should get allowed by `openid-connect` while the other one should get denied. This is the scenario I was facing in my organization's environment and gave the inspiration for the security fix. I am also having some issues testing locally the test cases, but it is more related to the needed openresty modules. I can always provide some proof from my instance, but I imagine this is not enough for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
