Revolyssup commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1540666022
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -326,6 +326,8 @@ data:
- name: "admin"
{{- if .Values.apisix.admin.credentials.secretName }}
key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+ {{- else if eq .Values.apisix.admin.credentials.admin "" }}
+ key: {{ randAlphaNum 32 }}
Review Comment:
Since this is in the confimap. Users can look at the configmap using kubectl
to look at the key. Is there an issue there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
