aikin-vip commented on code in PR #11060:
URL: https://github.com/apache/apisix/pull/11060#discussion_r1556762619
##########
apisix/plugins/request-id.lua:
##########
@@ -79,8 +95,9 @@ local function get_request_id(conf)
if conf.algorithm == "uuid" then
return uuid()
end
+
if conf.algorithm == "nanoid" then
- return nanoid.safe_simple()
+ return nanoid.generate(conf.nanoid.length,conf.nanoid.char_set)
Review Comment:
> space needed after comma
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
