AlinsRan commented on code in PR #706:
URL: https://github.com/apache/apisix-helm-chart/pull/706#discussion_r1557069718
##########
charts/apisix-ingress-controller/templates/servicemonitor.yaml:
##########
@@ -30,8 +30,9 @@ metadata:
{{- end }}
spec:
endpoints:
- - targetPort: http
+ - targetPort: prometheus
Review Comment:
The original HTTP should be the metrics of ingress.
You should add servicemonitor instead of replacing it.
Why replace it with the metrics of the data plane?
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/service-monitor.yaml#L41
How did you deploy it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
