kayx23 commented on code in PR #11160:
URL: https://github.com/apache/apisix/pull/11160#discussion_r1568093910
##########
docs/en/latest/installation-guide.md:
##########
@@ -271,9 +272,11 @@ You can configure your APISIX deployment in two ways:
apisix start -c <path to config file>
```
-APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
+APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your
configuration file will be present at `/usr/local/apisix/conf/` path.
+
+In case you get the Port binding logs when trying to run the APISIX server
using `apisix start` command, it is most likely that the ports are being used
by certain processes running on your machine. Try deleting the process using
the port or configure the default listening port to other available port on
your local machine.
-For example, to configure the default listening port to be `8000` without
changing other configurations, your configuration file could look like this:
+In order to configure the default listening port to be `8000` without changing
other configurations, your configuration file could look like this:
Review Comment:
Why the change here? `For example` + `could` sound like a pair providing a
sample config, but now the instruction sounds definitive, which it should not
be.
##########
docs/en/latest/installation-guide.md:
##########
@@ -271,9 +272,11 @@ You can configure your APISIX deployment in two ways:
apisix start -c <path to config file>
```
-APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
+APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your
configuration file will be present at `/usr/local/apisix/conf/` path.
+
+In case you get the Port binding logs when trying to run the APISIX server
using `apisix start` command, it is most likely that the ports are being used
by certain processes running on your machine. Try deleting the process using
the port or configure the default listening port to other available port on
your local machine.
Review Comment:
`deleting the process` --> `killing the process`
##########
docs/en/latest/installation-guide.md:
##########
@@ -271,9 +272,11 @@ You can configure your APISIX deployment in two ways:
apisix start -c <path to config file>
```
-APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
+APISIX will use the configurations added in this configuration file and will
fall back to the default configuration if anything is not configured.
Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your
configuration file will be present at `/usr/local/apisix/conf/` path.
+
+In case you get the Port binding logs when trying to run the APISIX server
using `apisix start` command, it is most likely that the ports are being used
by certain processes running on your machine. Try deleting the process using
the port or configure the default listening port to other available port on
your local machine.
Review Comment:
What `Port binding logs`? Be specific of the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
