moonming commented on code in PR #751:
URL: https://github.com/apache/apisix-helm-chart/pull/751#discussion_r1568274280
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -66,6 +66,7 @@ data:
enable_dev_mode: false # Sets nginx
worker_processes to 1 if set to true
enable_reuseport: true # Enable nginx SO_REUSEPORT
switch if set to true.
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
+ enable_http2: {{ .Values.apisix.ssl.http2.enabled }}
Review Comment:
```suggestion
enable_http2: {{ .Values.apisix.enableHTTP2}}
```
##########
charts/apisix/values.yaml:
##########
@@ -29,7 +29,7 @@ image:
pullPolicy: IfNotPresent
# -- Apache APISIX image tag
# Overrides the image tag whose default is the chart appVersion.
- tag: 3.8.0-debian
+ tag: 3.9.0-debian
Review Comment:
we should move `enable_http2`
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L274
under `apisix` in this file, just like
https://github.com/apache/apisix/pull/11032/files#diff-8d872babc717e9d733641b56bfc530ef98751fbe4e68f08d79b2b83109c22fffR36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
