bzp2010 opened a new pull request, #11277:
URL: https://github.com/apache/apisix/pull/11277

   ### Description
   
   HashiCorp Cloud and Enterprise editions support multi-tenancy based on the 
namespace concept. By using a specific HTTP Header, we can get the key from a 
specific namespace.
   
   This makes sense, for HashiCorp Cloud it looks like namespaces are turned on 
by default and its default namespace is admin, which will not work when the 
client (APISIX) does not specify a namespace.
   
   This PR adds namespace support on HCV (HashiCorp Vault).
   
   ### Addition
   
   **In addition to this, I would suggest to rename the `vault` module in 
APISIX to `hcv`, based on the fact that `vault` itself is a neutral term that 
stands for some kind of component used to store keys. `HashiCorp Vault` is the 
name of that software, so it should be written `hcv` and not `vault`.**
   
   **I would suggest renaming it, and in the meantime, we could add some sort 
of aliasing mechanism to continue to support users who use `vault` until APISIX 
4.0, when we can remove support for the old name.**
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to