nfrankel opened a new pull request, #11284:
URL: https://github.com/apache/apisix/pull/11284

   ### Description
   
   Regular OpenTelemetry Tracing uses environment variable for configuration. 
This way, Ops don't need to understand the details of each stack to configure 
OTEL.
   
   Here's a sample Docker Compose snippet where each stack is implemented on a 
different technology. Note that all abide by the same environement variables.
   
   ```yaml
     pricing:                      #python
       image: otel-pricing:1.1
       environment:
         OTEL_EXPORTER_OTLP_ENDPOINT: http://jaeger:4317
         OTEL_RESOURCE_ATTRIBUTES: service.name=pricing
         OTEL_METRICS_EXPORTER: none
         OTEL_LOGS_EXPORTER: none
     inventory:                 #rust
       image: otel-inventory:1.0
       environment:
         OTEL_EXPORTER_OTLP_ENDPOINT: http://jaeger:4317
         OTEL_RESOURCE_ATTRIBUTES: service.name=inventory
         OTEL_METRICS_EXPORTER: none
         OTEL_LOGS_EXPORTER: none
     warehouse-us:        #golang
       image: otel-warehouse-us:1.0
       environment:
         OTEL_EXPORTER_OTLP_ENDPOINT: http://jaeger:4317
         OTEL_RESOURCE_ATTRIBUTES: service.name=stocks USA
         OTEL_METRICS_EXPORTER: none
         OTEL_LOGS_EXPORTER: none
     warehouse-jp:      #ruby
       image: otel-warehouse-jp:1.0
       environment:
         OTEL_EXPORTER_OTLP_ENDPOINT: http://jaeger:4318
         OTEL_RESOURCE_ATTRIBUTES: service.name=stocks Japan
         OTEL_METRICS_EXPORTER: none
         OTEL_LOGS_EXPORTER: none
   ```
   
   This PR is a starting point to allow Apache APISIX to follow the same 
conventions.
   
   Two things of note, that should be discussed in this PR:
   
   * The default OTEL values defined in the spec are not the same as those 
defined by APISIX
   * The units defined in the spec are not the same as those defined by APISIX
   
   ### Checklist
   
   - [X] I have explained the need for this PR and the problem it solves
   - [X] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [X] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to