RocFang opened a new pull request #2390:
URL: https://github.com/apache/apisix/pull/2390
### What this PR does / why we need it:
1. the result below will always be false ,since etcd_version is nil:
```lua
if (etcd_version == "v3" and not res:find("OK", 1, true)) then
is_success = false
if (index == host_count) then
error(cmd .. "\n" .. res)
end
break
end
```
and since etcd_version has been checked before, I think maybe there is no
need to check it again here.
2. cluster_version has been defined previously, no need to define a new
local one.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
