heresie commented on code in PR #756:
URL: https://github.com/apache/apisix-helm-chart/pull/756#discussion_r1672553695
##########
charts/apisix/templates/service-gateway.yaml:
##########
@@ -76,6 +76,24 @@ spec:
port: {{ .port }}
targetPort: {{ .port }}
{{- end }}
+ {{- if or .Values.service.proxyProtocol.http.enabled }}
+ - name: apisix-gateway-pp-http
+ port: {{ .Values.service.proxyProtocol.http.servicePort }}
+ targetPort: {{ .Values.service.proxyProtocol.http.containerPort }}
Review Comment:
Declaring containerPorts on the Deployment is not mandatory to allow
communication. However you are right, it's better to have them so it helps
understanding.
##########
charts/apisix/templates/service-gateway.yaml:
##########
@@ -76,6 +76,24 @@ spec:
port: {{ .port }}
targetPort: {{ .port }}
{{- end }}
+ {{- if or .Values.service.proxyProtocol.http.enabled }}
+ - name: apisix-gateway-pp-http
+ port: {{ .Values.service.proxyProtocol.http.servicePort }}
+ targetPort: {{ .Values.service.proxyProtocol.http.containerPort }}
Review Comment:
Hello @yunerou,
Declaring containerPorts on the Deployment is not mandatory to allow
communication. However you are right, it's better to have them so it helps
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
