vicaya commented on code in PR #761: URL: https://github.com/apache/apisix-helm-chart/pull/761#discussion_r1674847180
########## charts/apisix-ingress-controller/templates/service.yaml: ########## Review Comment: The composite architecture using the same pod has been implemented for a while. Your current changes doesn't have a separate pod running apisix, AFAICT. Using a separate pod is problematic anyway, as it means that you have to reinvent security between etcd and apisix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
