bzp2010 commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1676773179
##########
apisix/discovery/nacos/init.lua:
##########
@@ -405,12 +434,17 @@ function _M.init_worker()
return
end
- default_weight = local_conf.discovery.nacos.weight
- log.info('default_weight:', default_weight)
+ --default_weight = local_conf.discovery.nacos.weight
+ --log.info('default_weight:', default_weight)
+ if local_conf.discovery.nacos.host
+ then
+ log.warn("config \"naocs.host\" will be deprecated soon.")
+ end
+
local fetch_interval = local_conf.discovery.nacos.fetch_interval
log.info('fetch_interval:', fetch_interval)
- access_key = local_conf.discovery.nacos.access_key
- secret_key = local_conf.discovery.nacos.secret_key
+ --access_key = local_conf.discovery.nacos.access_key
+ --secret_key = local_conf.discovery.nacos.secret_key
Review Comment:
Delete them if they are no longer used too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
