bzp2010 commented on code in PR #11403:
URL: https://github.com/apache/apisix/pull/11403#discussion_r1682321756
##########
apisix/plugins/authz-keycloak.lua:
##########
@@ -114,6 +114,11 @@ local _M = {
function _M.check_schema(conf)
+ local check = {"discovery", "token_endpoint",
"resource_registration_endpoint",
+ "access_denied_redirect_uri"}
+ core.utils.check_https(check, conf, plugin_name)
+ core.utils.check_tls_bool({conf.ssl_verify}, {"ssl_verify"}, plugin_name)
Review Comment:
I mean `check` and `conf` seem to be reversed. And it seems that
`check_tls_bool` can continue to use the string pattern in `check_https` to get
data in conf instead of supplying it upfront in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
