flearc commented on code in PR #11310:
URL: https://github.com/apache/apisix/pull/11310#discussion_r1683700742
##########
apisix/plugins/log-rotate.lua:
##########
@@ -189,10 +189,8 @@ end
local function init_default_logs(logs_info, log_type)
local filepath, filename = get_log_path_info(log_type)
logs_info[log_type] = { type = log_type }
- if filename ~= "off" then
Review Comment:
@shreemaan-abhishek Could you please review this PR? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
