zhoujiexiong commented on code in PR #11450:
URL: https://github.com/apache/apisix/pull/11450#discussion_r1699576819


##########
apisix/plugins/authz-casdoor.lua:
##########
@@ -60,7 +61,7 @@ local function fetch_access_token(code, conf)
             ["Content-Type"] = "application/x-www-form-urlencoded"
         }
     })
-
+    connection_util.close_http_connection(client)

Review Comment:
   `request_uri` will close(sock) before returning, so this line is not 
necessary? The same is true elsewhere of the PR.
   
   
![image](https://github.com/user-attachments/assets/8a084a61-a294-4d8f-8d7e-a2993c853d02)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to