TheShubhendra commented on code in PR #558:
URL: https://github.com/apache/apisix-docker/pull/558#discussion_r1716400592
##########
redhat/docker-entrypoint.sh:
##########
@@ -31,10 +31,29 @@ deployment:
config_provider: yaml
_EOC_
else
- # updating config.yaml for standalone mode
- echo "$(sed 's/role: traditional/role: data_plane/g'
${PREFIX}/conf/config.yaml)" > ${PREFIX}/conf/config.yaml
- echo "$(sed 's/role_traditional:/role_data_plane:/g'
${PREFIX}/conf/config.yaml)" > ${PREFIX}/conf/config.yaml
- echo "$(sed 's/config_provider: etcd/config_provider: yaml/g'
${PREFIX}/conf/config.yaml)" > ${PREFIX}/conf/config.yaml
+ # Check if the deployment role is set to data_plane and config
provider is set to yaml for standalone mode
Review Comment:
Thank you for your suggestion. What we can do is extract the logic into a
single file and place it in the root directory. Then, we can modify the
Makefile to copy this file into the appropriate build context directories
(e.g., /debian, /redhat, and /debian-dev) before the Docker build process, and
remove it afterward.
Please share your thoughts on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
