kayx23 commented on code in PR #11133:
URL: https://github.com/apache/apisix/pull/11133#discussion_r1719578897


##########
docs/en/latest/plugins/kafka-logger.md:
##########
@@ -55,8 +55,10 @@ It might take some time to receive the log data. It will be 
automatically sent a
 | log_format | object | False    |   |               | Log format declared as 
key value pairs in JSON format. Values only support strings. 
[APISIX](../apisix-variable.md) or 
[Nginx](http://nginx.org/en/docs/varindex.html) variables can be used by 
prefixing the string with `$`. |
 | include_req_body       | boolean | False    | false          | [false, true] 
        | When set to `true` includes the request body in the log. If the 
request body is too big to be kept in the memory, it can't be logged due to 
Nginx's limitations.                                                            
                                                                                
                                     |
 | include_req_body_expr  | array   | False    |                |               
        | Filter for when the `include_req_body` attribute is set to `true`. 
Request body is only logged when the expression set here evaluates to `true`. 
See [lua-resty-expr](https://github.com/api7/lua-resty-expr) for more.          
                                                                                
                                |
+| max_req_body_bytes     | integer | False    | 524288         | >=1           
        | Request bodies within this size will be pushed to kafka, if the size 
exceeds the configured value it will be truncated before pushing to Kafka.      
                                                                                
                                                                                
                            |
 | include_resp_body      | boolean | False    | false          | [false, true] 
        | When set to `true` includes the response body in the log.             
                                                                                
                                                                                
                                                                                
                           |
 | include_resp_body_expr | array   | False    |                |               
        | Filter for when the `include_resp_body` attribute is set to `true`. 
Response body is only logged when the expression set here evaluates to `true`. 
See [lua-resty-expr](https://github.com/api7/lua-resty-expr) for more.          
                                                                                
                              |
+| max_resp_body_bytes    | integer | False    | 524288         | >=1           
        | Request bodies within this size will be pushed to kafka, if the size 
exceeds the configured value it will be truncated before pushing to Kafka.      
                                                                                
                                                                                
                            |

Review Comment:
   @shreemaan-abhishek this should be response bodies eh?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to