moonming commented on a change in pull request #2374:
URL: https://github.com/apache/apisix/pull/2374#discussion_r503639787
##########
File path: bin/apisix
##########
@@ -1065,6 +1065,9 @@ local openresty_args = [[openresty -p ]] .. apisix_home
.. [[ -c ]]
.. apisix_home .. [[/conf/nginx.conf]]
function _M.start(...)
+
+ local cmd_logs = "mkdir -p " .. apisix_home .. "/logs"
Review comment:
I don't think is a good idea to create directories. What if the user
start apisix by sudo? Does the worker still have permission to write logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
