shreemaan-abhishek commented on code in PR #11445:
URL: https://github.com/apache/apisix/pull/11445#discussion_r1744823901
##########
apisix/plugins/cas-auth.lua:
##########
@@ -87,6 +89,9 @@ local function with_session_id(conf, ctx, session_id)
else
-- refresh the TTL
store:set(session_id, user, SESSION_LIFETIME)
+ if conf.set_user_header then
Review Comment:
never mind, I understood what you are trying to do.
> I'm fine with removing set_user_header, and having user_header empty by
default.
please push this change then we can resolve this conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
