kayx23 commented on code in PR #11569:
URL: https://github.com/apache/apisix/pull/11569#discussion_r1756149386
##########
docs/en/latest/admin-api.md:
##########
@@ -1497,6 +1497,102 @@ HTTP/1.1 200 OK
{"key":"\/apisix\/secrets\/vault\/test2","value":{"id":"vault\/test2","token":"apisix","prefix":"apisix","update_time":1669625828,"create_time":1669625828,"uri":"http:\/\/xxx\/get"}}
```
+When `{secretmanager}` is `aws`:
Review Comment:
It would be sectionally more clear to use h4 title. e.g.
* change `When {secretmanager} is vault:` to `#### When Secret Manager is
Vault`
* change `When {secretmanager}` is aws :` to `#### When Secret Manager is
AWS`
* change `When {secretmanager}` is gap :` to `#### When Secret Manager is
GCP`
##########
docs/en/latest/admin-api.md:
##########
@@ -1497,6 +1497,102 @@ HTTP/1.1 200 OK
{"key":"\/apisix\/secrets\/vault\/test2","value":{"id":"vault\/test2","token":"apisix","prefix":"apisix","update_time":1669625828,"create_time":1669625828,"uri":"http:\/\/xxx\/get"}}
```
+When `{secretmanager}` is `aws`:
Review Comment:
It would be sectionally more clear to use h4 title. e.g.
* change `When {secretmanager} is vault:` to `#### When Secret Manager is
Vault`
* change `When {secretmanager} is aws :` to `#### When Secret Manager is AWS`
* change `When {secretmanager} is gap :` to `#### When Secret Manager is GCP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
