nic-6443 commented on code in PR #11597:
URL: https://github.com/apache/apisix/pull/11597#discussion_r1772866943
##########
apisix/plugins/jwt-auth.lua:
##########
@@ -235,15 +230,10 @@ local function get_rsa_or_ecdsa_keypair(conf)
local public_key = conf.public_key
local private_key = conf.private_key
- if public_key and private_key then
- return public_key, private_key
- elseif public_key and not private_key then
- return nil, nil, "missing private key"
- elseif not public_key and private_key then
+ if not public_key then
return nil, nil, "missing public key"
- else
- return nil, nil, "public and private keys are missing"
end
+ return public_key, private_key
Review Comment:
Why is there still a `private_key`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]